Skip to content

This PR is to add comments to Test_parseFSInfoFromConfigMap in pkg/ddc/juicefs/datasetinfo_parser_test.go.#4531

Merged
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
0112Han:feature-add-comments
Mar 10, 2025
Merged

This PR is to add comments to Test_parseFSInfoFromConfigMap in pkg/ddc/juicefs/datasetinfo_parser_test.go.#4531
fluid-e2e-bot[bot] merged 2 commits intofluid-cloudnative:masterfrom
0112Han:feature-add-comments

Conversation

@0112Han
Copy link
Copy Markdown
Contributor

@0112Han 0112Han commented Mar 5, 2025

Ⅰ. Describe what this PR does
This PR adds documentation comments to the unit test function Test_parseFSInfoFromConfigMap
in pkg/ddc/juicefs/datasetinfo_parser_test.go. These comments improve the readability of
the function by describing its purpose and the steps involved in the test cases.

Ⅱ. Does this pull request fix one issue?
fixes #1

Ⅲ. Special notes for reviews
Please check if the comments clearly describe the function's purpose and test process.
Any suggestions for better clarity are welcome.

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 5, 2025

Hi @0112Han. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

Hello @0112Han , please fix the DCO Issue by following https://github.com/fluid-cloudnative/fluid/pull/4531/checks?check_run_id=38233858377

Comment thread pkg/ddc/juicefs/datasetinfo_parser_test.go
@0112Han 0112Han force-pushed the feature-add-comments branch from f587f3e to e7dee0c Compare March 7, 2025 02:57
0112Han added 2 commits March 7, 2025 11:14
…setinfo_parser_test.go

Signed-off-by: 0112Han <15829229836@163.com>
Signed-off-by: 0112Han <15829229836@163.com>
@0112Han 0112Han force-pushed the feature-add-comments branch from 67b427d to ec87aa8 Compare March 7, 2025 03:28
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 7, 2025

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot Bot merged commit 19a5367 into fluid-cloudnative:master Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create docs for dev

3 participants